Commit b9d05200 authored by Tom Lendacky's avatar Tom Lendacky Committed by Ingo Molnar
Browse files

x86/mm: Insure that boot memory areas are mapped properly 



The boot data and command line data are present in memory in a decrypted
state and are copied early in the boot process.  The early page fault
support will map these areas as encrypted, so before attempting to copy
them, add decrypted mappings so the data is accessed properly when copied.

For the initrd, encrypt this data in place. Since the future mapping of
the initrd area will be mapped as encrypted the data will be accessed
properly.

Signed-off-by: default avatarTom Lendacky <thomas.lendacky@amd.com>
Reviewed-by: default avatarThomas Gleixner <tglx@linutronix.de>
Cc: Alexander Potapenko <glider@google.com>
Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brijesh Singh <brijesh.singh@amd.com>
Cc: Dave Young <dyoung@redhat.com>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Larry Woodman <lwoodman@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Matt Fleming <matt@codeblueprint.co.uk>
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Radim Krčmář <rkrcmar@redhat.com>
Cc: Rik van Riel <riel@redhat.com>
Cc: Toshimitsu Kani <toshi.kani@hpe.com>
Cc: kasan-dev@googlegroups.com
Cc: kvm@vger.kernel.org
Cc: linux-arch@vger.kernel.org
Cc: linux-doc@vger.kernel.org
Cc: linux-efi@vger.kernel.org
Cc: linux-mm@kvack.org
Link: http://lkml.kernel.org/r/bb0d430b41efefd45ee515aaf0979dcfda8b6a44.1500319216.git.thomas.lendacky@amd.com


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 7f8b7e7f

arch/x86/include/asm/mem_encrypt.h

+6 −0
Original line number Diff line number Diff line
@@ -26,6 +26,9 @@ void __init sme_early_encrypt(resource_size_t paddr, 
void __init sme_early_decrypt(resource_size_t paddr,

			      unsigned long size);



void __init sme_map_bootdata(char *real_mode_data);

void __init sme_unmap_bootdata(char *real_mode_data);



void __init sme_early_init(void);



void __init sme_encrypt_kernel(void);
@@ -40,6 +43,9 @@ static inline void __init sme_early_encrypt(resource_size_t paddr, 
static inline void __init sme_early_decrypt(resource_size_t paddr,

					    unsigned long size) { }



static inline void __init sme_map_bootdata(char *real_mode_data) { }

static inline void __init sme_unmap_bootdata(char *real_mode_data) { }



static inline void __init sme_early_init(void) { }



static inline void __init sme_encrypt_kernel(void) { }

arch/x86/include/asm/pgtable.h

+3 −0
Original line number Diff line number Diff line
@@ -23,6 +23,9 @@ 
#ifndef __ASSEMBLY__

#include <asm/x86_init.h>



extern pgd_t early_top_pgt[PTRS_PER_PGD];

int __init __early_make_pgtable(unsigned long address, pmdval_t pmd);



void ptdump_walk_pgd_level(struct seq_file *m, pgd_t *pgd);

void ptdump_walk_pgd_level_checkwx(void);

arch/x86/kernel/head64.c

+26 −4
Original line number Diff line number Diff line
@@ -34,7 +34,6 @@ 
/*

 * Manage page tables very early on.

 */

extern pgd_t early_top_pgt[PTRS_PER_PGD];

extern pmd_t early_dynamic_pgts[EARLY_DYNAMIC_PAGE_TABLES][PTRS_PER_PMD];

static unsigned int __initdata next_early_pgt;

pmdval_t early_pmd_flags = __PAGE_KERNEL_LARGE & ~(_PAGE_GLOBAL | _PAGE_NX);
@@ -181,13 +180,13 @@ static void __init reset_early_page_tables(void) 
}



/* Create a new PMD entry */

int __init early_make_pgtable(unsigned long address)

int __init __early_make_pgtable(unsigned long address, pmdval_t pmd)

{

	unsigned long physaddr = address - __PAGE_OFFSET;

	pgdval_t pgd, *pgd_p;

	p4dval_t p4d, *p4d_p;

	pudval_t pud, *pud_p;

	pmdval_t pmd, *pmd_p;

	pmdval_t *pmd_p;



	/* Invalid address or early pgt is done ?  */

	if (physaddr >= MAXMEM || read_cr3_pa() != __pa_nodebug(early_top_pgt))
@@ -246,12 +245,21 @@ again: 
		memset(pmd_p, 0, sizeof(*pmd_p) * PTRS_PER_PMD);

		*pud_p = (pudval_t)pmd_p - __START_KERNEL_map + phys_base + _KERNPG_TABLE;

	}

	pmd = (physaddr & PMD_MASK) + early_pmd_flags;

	pmd_p[pmd_index(address)] = pmd;



	return 0;

}



int __init early_make_pgtable(unsigned long address)

{

	unsigned long physaddr = address - __PAGE_OFFSET;

	pmdval_t pmd;



	pmd = (physaddr & PMD_MASK) + early_pmd_flags;



	return __early_make_pgtable(address, pmd);

}



/* Don't add a printk in there. printk relies on the PDA which is not initialized 

   yet. */

static void __init clear_bss(void)
@@ -274,6 +282,12 @@ static void __init copy_bootdata(char *real_mode_data) 
	char * command_line;

	unsigned long cmd_line_ptr;



	/*

	 * If SME is active, this will create decrypted mappings of the

	 * boot data in advance of the copy operations.

	 */

	sme_map_bootdata(real_mode_data);



	memcpy(&boot_params, real_mode_data, sizeof boot_params);

	sanitize_boot_params(&boot_params);

	cmd_line_ptr = get_cmd_line_ptr();
@@ -281,6 +295,14 @@ static void __init copy_bootdata(char *real_mode_data) 
		command_line = __va(cmd_line_ptr);

		memcpy(boot_command_line, command_line, COMMAND_LINE_SIZE);

	}



	/*

	 * The old boot data is no longer needed and won't be reserved,

	 * freeing up that memory for use by the system. If SME is active,

	 * we need to remove the mappings that were created so that the

	 * memory doesn't remain mapped as decrypted.

	 */

	sme_unmap_bootdata(real_mode_data);

}



asmlinkage __visible void __init x86_64_start_kernel(char * real_mode_data)

arch/x86/kernel/setup.c

+9 −0
Original line number Diff line number Diff line
@@ -69,6 +69,7 @@ 
#include <linux/crash_dump.h>

#include <linux/tboot.h>

#include <linux/jiffies.h>

#include <linux/mem_encrypt.h>



#include <linux/usb/xhci-dbgp.h>

#include <video/edid.h>
@@ -374,6 +375,14 @@ static void __init reserve_initrd(void) 
	    !ramdisk_image || !ramdisk_size)

		return;		/* No initrd provided by bootloader */



	/*

	 * If SME is active, this memory will be marked encrypted by the

	 * kernel when it is accessed (including relocation). However, the

	 * ramdisk image was loaded decrypted by the bootloader, so make

	 * sure that it is encrypted before accessing it.

	 */

	sme_early_encrypt(ramdisk_image, ramdisk_end - ramdisk_image);



	initrd_start = 0;



	mapped_size = memblock_mem_size(max_pfn_mapped);

arch/x86/mm/kasan_init_64.c

+1 −1
Original line number Diff line number Diff line
@@ -11,8 +11,8 @@ 
#include <asm/e820/types.h>

#include <asm/tlbflush.h>

#include <asm/sections.h>

#include <asm/pgtable.h>



extern pgd_t early_top_pgt[PTRS_PER_PGD];

extern struct range pfn_mapped[E820_MAX_ENTRIES];



static int __init map_range(struct range *range)

CRA Git | Maintained and supported by SUSTech CRA and CCSE