Commit b9bec768 authored Aug 21, 2006 by Zhu Yi Committed by John W. Linville Aug 29, 2006

[PATCH] ipw2200: Fix kernel Oops if cmdlog debug is enabled



When command error log debug is enabled, we write every host command and
parameters into a buffer. But we didn't alloc the parameter buffer for this
case. The patch adds struct cmdlog_host_cmd so that the buffer is allocated
from the stack.

Signed-off-by: Zhu Yi <yi.zhu@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

parent d5f7ac20

drivers/net/wireless/ipw2200.h

+8 −1

Original line number	Diff line number	Diff line
		@@ -1950,10 +1950,17 @@ struct host_cmd {
		u32 *param;
		} __attribute__ ((packed));

		struct cmdlog_host_cmd {
		u8 cmd;
		u8 len;
		u16 reserved;
		char param[124];
		} __attribute__ ((packed));

		struct ipw_cmd_log {
		unsigned long jiffies;
		int retcode;
		struct host_cmd cmd;
		struct cmdlog_host_cmd cmd;
		};

		/* SysConfig command parameters ... */

Admin message