Commit b9be6d02 authored Sep 14, 2013 by Wang YanQing Committed by Steven Rostedt Oct 09, 2013

tracing: Show more exact help information about snapshot

The current "help" that comes out of the snapshot file when it is
not allocated looks like this:

 # * Snapshot is freed *
 #
 # Snapshot commands:
 # echo 0 > snapshot : Clears and frees snapshot buffer
 # echo 1 > snapshot : Allocates snapshot buffer, if not already allocated.
 #                      Takes a snapshot of the main buffer.
 # echo 2 > snapshot : Clears snapshot buffer (but does not allocate)
 #                      (Doesn't have to be '2' works with any number that
 #                       is not a '0' or '1')

Echo 2 says that it does not allocate the buffer, which is correct,
but to be more consistent with "echo 0" it should also state
that it does not free.

Link: http://lkml.kernel.org/r/20130914045916.GA4243@udknight



Signed-off-by: Wang YanQing <udknight@gmail.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

parent d0e639c9

kernel/trace/trace.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2760,7 +2760,7 @@ static void show_snapshot_main_help(struct seq_file *m)
		seq_printf(m, "# echo 0 > snapshot : Clears and frees snapshot buffer\n");
		seq_printf(m, "# echo 1 > snapshot : Allocates snapshot buffer, if not already allocated.\n");
		seq_printf(m, "# Takes a snapshot of the main buffer.\n");
		seq_printf(m, "# echo 2 > snapshot : Clears snapshot buffer (but does not allocate)\n");
		seq_printf(m, "# echo 2 > snapshot : Clears snapshot buffer (but does not allocate or free)\n");
		seq_printf(m, "# (Doesn't have to be '2' works with any number that\n");
		seq_printf(m, "# is not a '0' or '1')\n");
		}

Admin message