Commit b9bcc919 authored Jun 16, 2015 by Dave P Martin Committed by Catalin Marinas Jun 17, 2015

arm64: mm: Fix freeing of the wrong memmap entries with !SPARSEMEM_VMEMMAP



The memmap freeing code in free_unused_memmap() computes the end of
each memblock by adding the memblock size onto the base.  However,
if SPARSEMEM is enabled then the value (start) used for the base
may already have been rounded downwards to work out which memmap
entries to free after the previous memblock.

This may cause memmap entries that are in use to get freed.

In general, you're not likely to hit this problem unless there
are at least 2 memblocks and one of them is not aligned to a
sparsemem section boundary.  Note that carve-outs can increase
the number of memblocks by splitting the regions listed in the
device tree.

This problem doesn't occur with SPARSEMEM_VMEMMAP, because the
vmemmap code deals with freeing the unused regions of the memmap
instead of requiring the arch code to do it.

This patch gets the memblock base out of the memblock directly when
computing the block end address to ensure the correct value is used.

Signed-off-by: Dave Martin <Dave.Martin@arm.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>

parent 46b0567c

arch/arm64/mm/init.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -262,7 +262,7 @@ static void __init free_unused_memmap(void)
		* memmap entries are valid from the bank end aligned to
		* MAX_ORDER_NR_PAGES.
		*/
		prev_end = ALIGN(start + __phys_to_pfn(reg->size),
		prev_end = ALIGN(__phys_to_pfn(reg->base + reg->size),
		MAX_ORDER_NR_PAGES);
		}

Admin message