Commit b9a7b883 authored by Valentin Schneider's avatar Valentin Schneider Committed by Ingo Molnar
Browse files

sched/fair: Skip LLC NOHZ logic for asymmetric systems 



The LLC NOHZ condition will become true as soon as >=2 CPUs in a
single LLC domain are busy. On big.LITTLE systems, this translates to
two or more CPUs of a "cluster" (big or LITTLE) being busy.

Issuing a NOHZ kick in these conditions isn't desired for asymmetric
systems, as if the busy CPUs can provide enough compute capacity to
the running tasks, then we can leave the NOHZ CPUs in peace.

Skip the LLC NOHZ condition for asymmetric systems, and rely on
nr_running & capacity checks to trigger NOHZ kicks when the system
actually needs them.

Suggested-by: default avatarMorten Rasmussen <morten.rasmussen@arm.com>
Signed-off-by: default avatarValentin Schneider <valentin.schneider@arm.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Dietmar.Eggemann@arm.com
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Rik van Riel <riel@surriel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: vincent.guittot@linaro.org
Link: https://lkml.kernel.org/r/20190211175946.4961-4-valentin.schneider@arm.com


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent a0fe2cf0

kernel/sched/fair.c

+37 −28
Original line number Diff line number Diff line
@@ -9603,37 +9603,34 @@ static void nohz_balancer_kick(struct rq *rq) 
	}



	rcu_read_lock();

	sds = rcu_dereference(per_cpu(sd_llc_shared, cpu));

	if (sds) {



	sd = rcu_dereference(rq->sd);

	if (sd) {

		/*

		 * If there is an imbalance between LLC domains (IOW we could

		 * increase the overall cache use), we need some less-loaded LLC

		 * domain to pull some load. Likewise, we may need to spread

		 * load within the current LLC domain (e.g. packed SMT cores but

		 * other CPUs are idle). We can't really know from here how busy

		 * the others are - so just get a nohz balance going if it looks

		 * like this LLC domain has tasks we could move.

		 * If there's a CFS task and the current CPU has reduced

		 * capacity; kick the ILB to see if there's a better CPU to run

		 * on.

		 */

		nr_busy = atomic_read(&sds->nr_busy_cpus);

		if (nr_busy > 1) {

		if (rq->cfs.h_nr_running >= 1 && check_cpu_capacity(rq, sd)) {

			flags = NOHZ_KICK_MASK;

			goto unlock;

		}



	}



	sd = rcu_dereference(rq->sd);

	sd = rcu_dereference(per_cpu(sd_asym_packing, cpu));

	if (sd) {

		/*

		 * If there's a CFS task and the current CPU has reduced

		 * capacity; kick the ILB to see if there's a better CPU to run

		 * on.

		 * When ASYM_PACKING; see if there's a more preferred CPU

		 * currently idle; in which case, kick the ILB to move tasks

		 * around.

		 */

		if (rq->cfs.h_nr_running >= 1 && check_cpu_capacity(rq, sd)) {

		for_each_cpu_and(i, sched_domain_span(sd), nohz.idle_cpus_mask) {

			if (sched_asym_prefer(i, cpu)) {

				flags = NOHZ_KICK_MASK;

				goto unlock;

			}

		}

	}



	sd = rcu_dereference(per_cpu(sd_asym_cpucapacity, cpu));

	if (sd) {
@@ -9645,22 +9642,34 @@ static void nohz_balancer_kick(struct rq *rq) 
			flags = NOHZ_KICK_MASK;

			goto unlock;

		}



		/*

		 * For asymmetric systems, we do not want to nicely balance

		 * cache use, instead we want to embrace asymmetry and only

		 * ensure tasks have enough CPU capacity.

		 *

		 * Skip the LLC logic because it's not relevant in that case.

		 */

		goto unlock;

	}



	sd = rcu_dereference(per_cpu(sd_asym_packing, cpu));

	if (sd) {

	sds = rcu_dereference(per_cpu(sd_llc_shared, cpu));

	if (sds) {

		/*

		 * When ASYM_PACKING; see if there's a more preferred CPU

		 * currently idle; in which case, kick the ILB to move tasks

		 * around.

		 * If there is an imbalance between LLC domains (IOW we could

		 * increase the overall cache use), we need some less-loaded LLC

		 * domain to pull some load. Likewise, we may need to spread

		 * load within the current LLC domain (e.g. packed SMT cores but

		 * other CPUs are idle). We can't really know from here how busy

		 * the others are - so just get a nohz balance going if it looks

		 * like this LLC domain has tasks we could move.

		 */

		for_each_cpu_and(i, sched_domain_span(sd), nohz.idle_cpus_mask) {

			if (sched_asym_prefer(i, cpu)) {

		nr_busy = atomic_read(&sds->nr_busy_cpus);

		if (nr_busy > 1) {

			flags = NOHZ_KICK_MASK;

			goto unlock;

		}

	}

	}

unlock:

	rcu_read_unlock();

out:

CRA Git | Maintained and supported by SUSTech CRA and CCSE