ASoC: SOF: imx8: Make some functions static (b9a4805a) · Commits · 戴 / test

Fix sparse warnings: sound/soc/sof/imx/imx8.c:104:6: warning: symbol 'imx8_dsp_handle_reply' was not declared. Should it be static? sound/soc/sof/imx/imx8.c:115:6: warning: symbol 'imx8_dsp_handle_request' was not declared. Should it be static? sound/soc/sof/imx/imx8.c:336:5: warning: symbol 'imx8_get_bar_index' was not declared. Should it be static? sound/soc/sof/imx/imx8.c:341:6: warning: symbol 'imx8_ipc_msg_data' was not declared. Should it be static? sound/soc/sof/imx/imx8.c:348:5: warning: symbol 'imx8_ipc_pcm_params' was not declared. Should it be static? Reported-by:

Hulk Robot <hulkci@huawei.com> Signed-off-by:

YueHaibing <yuehaibing@huawei.com> Reviewed-by:

Daniel Baluta <daniel.baluta@nxp.com> Link: https://lore.kernel.org/r/20190823125939.30012-1-yuehaibing@huawei.com Signed-off-by:

Mark Brown <broonie@kernel.org>

sound/soc/sof/imx/imx8.c

+9 −9

Original line number	Diff line number	Diff line
		@@ -101,7 +101,7 @@ static int imx8_get_window_offset(struct snd_sof_dev *sdev, u32 id)
		return MBOX_OFFSET;
		}

		void imx8_dsp_handle_reply(struct imx_dsp_ipc *ipc)
		static void imx8_dsp_handle_reply(struct imx_dsp_ipc *ipc)
		{
		struct imx8_priv *priv = imx_dsp_get_data(ipc);
		unsigned long flags;
		@@ -112,7 +112,7 @@ void imx8_dsp_handle_reply(struct imx_dsp_ipc *ipc)
		spin_unlock_irqrestore(&priv->sdev->ipc_lock, flags);
		}

		void imx8_dsp_handle_request(struct imx_dsp_ipc *ipc)
		static void imx8_dsp_handle_request(struct imx_dsp_ipc *ipc)
		{
		struct imx8_priv *priv = imx_dsp_get_data(ipc);

		@@ -333,19 +333,19 @@ static int imx8_remove(struct snd_sof_dev *sdev)
		}

		/* on i.MX8 there is 1 to 1 match between type and BAR idx */
		int imx8_get_bar_index(struct snd_sof_dev *sdev, u32 type)
		static int imx8_get_bar_index(struct snd_sof_dev *sdev, u32 type)
		{
		return type;
		}

		void imx8_ipc_msg_data(struct snd_sof_dev *sdev,
		static void imx8_ipc_msg_data(struct snd_sof_dev *sdev,
		struct snd_pcm_substream *substream,
		void *p, size_t sz)
		{
		sof_mailbox_read(sdev, sdev->dsp_box.offset, p, sz);
		}

		int imx8_ipc_pcm_params(struct snd_sof_dev *sdev,
		static int imx8_ipc_pcm_params(struct snd_sof_dev *sdev,
		struct snd_pcm_substream *substream,
		const struct sof_ipc_pcm_params_reply *reply)
		{

Admin message