Commit b997e3ed authored by Hans de Goede's avatar Hans de Goede Committed by Thierry Reding
Browse files

pwm: lpss: Set enable-bit before waiting for update-bit to go low 



At least on cherrytrail, the update bit will never go low when the
enabled bit is not set.

This causes the backlight on my cube iwork8 air tablet to never turn on
again after being turned off because in the pwm_lpss_apply enable path
pwm_lpss_update will fail causing an error exit and the enable-bit to
never get set. Any following pwm_lpss_apply calls will fail the
pwm_lpss_is_updating check.

Since the docs say that the update bit should be set before the
enable-bit, split pwm_lpss_update into setting the update-bit and
pwm_lpss_wait_for_update, and move the pwm_lpss_wait_for_update call
in the enable path to after setting the enable-bit.

Fixes: 10d56a4c ("pwm: lpss: Avoid reconfiguring while UPDATE bit...")
Cc: Ilkka Koskinen <ilkka.koskinen@intel.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tested-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
parent 3c1460e9

drivers/pwm/pwm-lpss-pci.c

+1 −0
Original line number Diff line number Diff line
@@ -36,6 +36,7 @@ static const struct pwm_lpss_boardinfo pwm_lpss_bxt_info = { 
	.clk_rate = 19200000,

	.npwm = 4,

	.base_unit_bits = 22,

	.bypass = true,

};



/* Tangier */

drivers/pwm/pwm-lpss-platform.c

+1 −0
Original line number Diff line number Diff line
@@ -37,6 +37,7 @@ static const struct pwm_lpss_boardinfo pwm_lpss_bxt_info = { 
	.clk_rate = 19200000,

	.npwm = 4,

	.base_unit_bits = 22,

	.bypass = true,

};



static int pwm_lpss_probe_platform(struct platform_device *pdev)

drivers/pwm/pwm-lpss.c

+13 −6
Original line number Diff line number Diff line
@@ -57,7 +57,7 @@ static inline void pwm_lpss_write(const struct pwm_device *pwm, u32 value) 
	writel(value, lpwm->regs + pwm->hwpwm * PWM_SIZE + PWM);

}



static int pwm_lpss_update(struct pwm_device *pwm)

static int pwm_lpss_wait_for_update(struct pwm_device *pwm)

{

	struct pwm_lpss_chip *lpwm = to_lpwm(pwm->chip);

	const void __iomem *addr = lpwm->regs + pwm->hwpwm * PWM_SIZE + PWM;
@@ -65,8 +65,6 @@ static int pwm_lpss_update(struct pwm_device *pwm) 
	u32 val;

	int err;



	pwm_lpss_write(pwm, pwm_lpss_read(pwm) | PWM_SW_UPDATE);



	/*

	 * PWM Configuration register has SW_UPDATE bit that is set when a new

	 * configuration is written to the register. The bit is automatically
@@ -122,6 +120,12 @@ static void pwm_lpss_prepare(struct pwm_lpss_chip *lpwm, struct pwm_device *pwm, 
	pwm_lpss_write(pwm, ctrl);

}



static inline void pwm_lpss_cond_enable(struct pwm_device *pwm, bool cond)

{

	if (cond)

		pwm_lpss_write(pwm, pwm_lpss_read(pwm) | PWM_ENABLE);

}



static int pwm_lpss_apply(struct pwm_chip *chip, struct pwm_device *pwm,

			  struct pwm_state *state)

{
@@ -137,18 +141,21 @@ static int pwm_lpss_apply(struct pwm_chip *chip, struct pwm_device *pwm, 
				return ret;

			}

			pwm_lpss_prepare(lpwm, pwm, state->duty_cycle, state->period);

			ret = pwm_lpss_update(pwm);

			pwm_lpss_write(pwm, pwm_lpss_read(pwm) | PWM_SW_UPDATE);

			pwm_lpss_cond_enable(pwm, lpwm->info->bypass == false);

			ret = pwm_lpss_wait_for_update(pwm);

			if (ret) {

				pm_runtime_put(chip->dev);

				return ret;

			}

			pwm_lpss_write(pwm, pwm_lpss_read(pwm) | PWM_ENABLE);

			pwm_lpss_cond_enable(pwm, lpwm->info->bypass == true);

		} else {

			ret = pwm_lpss_is_updating(pwm);

			if (ret)

				return ret;

			pwm_lpss_prepare(lpwm, pwm, state->duty_cycle, state->period);

			return pwm_lpss_update(pwm);

			pwm_lpss_write(pwm, pwm_lpss_read(pwm) | PWM_SW_UPDATE);

			return pwm_lpss_wait_for_update(pwm);

		}

	} else if (pwm_is_enabled(pwm)) {

		pwm_lpss_write(pwm, pwm_lpss_read(pwm) & ~PWM_ENABLE);

drivers/pwm/pwm-lpss.h

+1 −0
Original line number Diff line number Diff line
@@ -22,6 +22,7 @@ struct pwm_lpss_boardinfo { 
	unsigned long clk_rate;

	unsigned int npwm;

	unsigned long base_unit_bits;

	bool bypass;

};



struct pwm_lpss_chip *pwm_lpss_probe(struct device *dev, struct resource *r,

CRA Git | Maintained and supported by SUSTech CRA and CCSE