Commit b98c06b6 authored Dec 24, 2009 by Luis R. Rodriguez Committed by John W. Linville Dec 28, 2009

mac80211: fix race with suspend and dynamic_ps_disable_work

When mac80211 suspends it calls a driver's suspend callback
as a last step and after that the driver assumes no calls will
be made to it until we resume and its start callback is kicked.
If such calls are made, however, suspend can end up throwing
hardware in an unexpected state and making the device unusable
upon resume.

Fix this by preventing mac80211 to schedule dynamic_ps_disable_work
by checking for when mac80211 starts to suspend and starts
quiescing. Frames should be allowed to go through though as
that is part of the quiescing steps and we do not flush the
mac80211 workqueue since it was already done towards the
beginning of suspend cycle.

The other mac80211 issue will be hanled in the next patch.

For further details see refer to the thread:

http://marc.info/?t=126144866100001&r=1&w=2



Cc: stable@kernel.org
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

parent 5b479a07

net/mac80211/tx.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -1419,6 +1419,10 @@ static bool need_dynamic_ps(struct ieee80211_local *local)
		if (!local->ps_sdata)
		return false;

		/* No point if we're going to suspend */
		if (local->quiescing)
		return false;

		return true;
		}

Admin message