Commit b92fe9e3 authored Feb 16, 2016 by Sanchayan Maity Committed by Guenter Roeck Mar 05, 2016

hwmon: (iio_hwmon) Allow the driver to accept hypen in device tree node names



Currently the driver calls hwmon_device_register_with_groups which
does not accept hypen in node name and returns EINVAL. Use of hypen
in device tree node name results in probe failure., however use of
hypen in device tree node name is perfectly acceptable.

Change this by allocating a duplicate managed string, replacing
hypen with underscore and then calling hwmon_device_register_with_groups.
This allows the use of hypen in device tree node name while maintaining
backwards compatibility and preventing any possible regressions with
user space.

Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

parent df922703

drivers/hwmon/iio_hwmon.c

+10 −1

Original line number	Diff line number	Diff line
		@@ -67,6 +67,7 @@ static int iio_hwmon_probe(struct platform_device *pdev)
		enum iio_chan_type type;
		struct iio_channel *channels;
		const char *name = "iio_hwmon";
		char *sname;

		if (dev->of_node && dev->of_node->name)
		name = dev->of_node->name;
		@@ -144,7 +145,15 @@ static int iio_hwmon_probe(struct platform_device *pdev)

		st->attr_group.attrs = st->attrs;
		st->groups[0] = &st->attr_group;
		st->hwmon_dev = hwmon_device_register_with_groups(dev, name, st,

		sname = devm_kstrdup(dev, name, GFP_KERNEL);
		if (!sname) {
		ret = -ENOMEM;
		goto error_release_channels;
		}

		strreplace(sname, '-', '_');
		st->hwmon_dev = hwmon_device_register_with_groups(dev, sname, st,
		st->groups);
		if (IS_ERR(st->hwmon_dev)) {
		ret = PTR_ERR(st->hwmon_dev);

Admin message