Commit b92486cb authored by Alex Shi's avatar Alex Shi Committed by Ingo Molnar
Browse files

sched: Compute runnable load avg in cpu_load and cpu_avg_load_per_task 



They are the base values in load balance, update them with rq runnable
load average, then the load balance will consider runnable load avg
naturally.

We also try to include the blocked_load_avg as cpu load in balancing,
but that cause kbuild performance drop 6% on every Intel machine, and
aim7/oltp drop on some of 4 CPU sockets machines.
Or only add blocked_load_avg into get_rq_runable_load, hackbench still
drop a little on NHM EX.

Signed-off-by: default avatarAlex Shi <alex.shi@intel.com>
Reviewed-by: default avatarGu Zheng <guz.fnst@cn.fujitsu.com>
Signed-off-by: default avatarPeter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1371694737-29336-7-git-send-email-alex.shi@intel.com


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 83dfd523

kernel/sched/fair.c

+3 −2
Original line number Diff line number Diff line
@@ -2963,7 +2963,7 @@ static void dequeue_task_fair(struct rq *rq, struct task_struct *p, int flags) 
/* Used instead of source_load when we know the type == 0 */

static unsigned long weighted_cpuload(const int cpu)

{

	return cpu_rq(cpu)->load.weight;

	return cpu_rq(cpu)->cfs.runnable_load_avg;

}



/*
@@ -3008,9 +3008,10 @@ static unsigned long cpu_avg_load_per_task(int cpu) 
{

	struct rq *rq = cpu_rq(cpu);

	unsigned long nr_running = ACCESS_ONCE(rq->nr_running);

	unsigned long load_avg = rq->cfs.runnable_load_avg;



	if (nr_running)

		return rq->load.weight / nr_running;

		return load_avg / nr_running;



	return 0;

}

kernel/sched/proc.c

+15 −2
Original line number Diff line number Diff line
@@ -501,6 +501,18 @@ static void __update_cpu_load(struct rq *this_rq, unsigned long this_load, 
	sched_avg_update(this_rq);

}



#ifdef CONFIG_SMP

unsigned long get_rq_runnable_load(struct rq *rq)

{

	return rq->cfs.runnable_load_avg;

}

#else

unsigned long get_rq_runnable_load(struct rq *rq)

{

	return rq->load.weight;

}

#endif



#ifdef CONFIG_NO_HZ_COMMON

/*

 * There is no sane way to deal with nohz on smp when using jiffies because the
@@ -522,7 +534,7 @@ static void __update_cpu_load(struct rq *this_rq, unsigned long this_load, 
void update_idle_cpu_load(struct rq *this_rq)

{

	unsigned long curr_jiffies = ACCESS_ONCE(jiffies);

	unsigned long load = this_rq->load.weight;

	unsigned long load = get_rq_runnable_load(this_rq);

	unsigned long pending_updates;



	/*
@@ -568,11 +580,12 @@ void update_cpu_load_nohz(void) 
 */

void update_cpu_load_active(struct rq *this_rq)

{

	unsigned long load = get_rq_runnable_load(this_rq);

	/*

	 * See the mess around update_idle_cpu_load() / update_cpu_load_nohz().

	 */

	this_rq->last_load_update_tick = jiffies;

	__update_cpu_load(this_rq, this_rq->load.weight, 1);

	__update_cpu_load(this_rq, load, 1);



	calc_load_account_active(this_rq);

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE