Commit b9183975 authored Nov 16, 2009 by Eric Sandeen Committed by Jan Kara Dec 10, 2009

ext3: Don't update the superblock in ext3_statfs()



commit a71ce8c6 updated ext3_statfs()
to update the on-disk superblock counters, but modified this buffer
directly without any journaling of the change.  This is one of the
accesses that was causing the crc errors in journal replay as seen in
kernel.org bugzilla #14354.

The modifications were originally to keep the sb "more" in sync,
so that a readonly fsck of the device didn't flag this as an
error (as often), but apparently e2fsprogs deals with this differently
now, anyway.

Based on Ted's patch for ext4, which was in turn based on my
work on that bug and another preliminary patch...

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Jan Kara <jack@suse.cz>

parent d965736b

fs/ext3/super.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -2686,13 +2686,11 @@ static int ext3_statfs (struct dentry * dentry, struct kstatfs * buf)
		buf->f_bsize = sb->s_blocksize;
		buf->f_blocks = le32_to_cpu(es->s_blocks_count) - sbi->s_overhead_last;
		buf->f_bfree = percpu_counter_sum_positive(&sbi->s_freeblocks_counter);
		es->s_free_blocks_count = cpu_to_le32(buf->f_bfree);
		buf->f_bavail = buf->f_bfree - le32_to_cpu(es->s_r_blocks_count);
		if (buf->f_bfree < le32_to_cpu(es->s_r_blocks_count))
		buf->f_bavail = 0;
		buf->f_files = le32_to_cpu(es->s_inodes_count);
		buf->f_ffree = percpu_counter_sum_positive(&sbi->s_freeinodes_counter);
		es->s_free_inodes_count = cpu_to_le32(buf->f_ffree);
		buf->f_namelen = EXT3_NAME_LEN;
		fsid = le64_to_cpup((void *)es->s_uuid) ^
		le64_to_cpup((void *)es->s_uuid + sizeof(u64));

Admin message