Commit b90abaac authored by Guenter Roeck's avatar Guenter Roeck Committed by Wim Van Sebroeck
Browse files

watchdog: xen_wdt: Use 'dev' instead of dereferencing it repeatedly 

Introduce local variable 'struct device *dev' and use it instead of
dereferencing it repeatedly.

The conversion was done automatically with coccinelle using the
following semantic patches. The semantic patches and the scripts
used to generate this commit log are available at
https://github.com/groeck/coccinelle-patches



Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarWim Van Sebroeck <wim@linux-watchdog.org>
parent 30f57e0f

drivers/watchdog/xen_wdt.c

+9 −9
Original line number Diff line number Diff line
@@ -122,34 +122,34 @@ static struct watchdog_device xen_wdt_dev = { 


static int xen_wdt_probe(struct platform_device *pdev)

{

	struct device *dev = &pdev->dev;

	struct sched_watchdog wd = { .id = ~0 };

	int ret = HYPERVISOR_sched_op(SCHEDOP_watchdog, &wd);



	if (ret == -ENOSYS) {

		dev_err(&pdev->dev, "watchdog not supported by hypervisor\n");

		dev_err(dev, "watchdog not supported by hypervisor\n");

		return -ENODEV;

	}



	if (ret != -EINVAL) {

		dev_err(&pdev->dev, "unexpected hypervisor error (%d)\n", ret);

		dev_err(dev, "unexpected hypervisor error (%d)\n", ret);

		return -ENODEV;

	}



	if (watchdog_init_timeout(&xen_wdt_dev, timeout, NULL))

		dev_info(&pdev->dev, "timeout value invalid, using %d\n",

		dev_info(dev, "timeout value invalid, using %d\n",

			 xen_wdt_dev.timeout);

	watchdog_set_nowayout(&xen_wdt_dev, nowayout);

	watchdog_stop_on_reboot(&xen_wdt_dev);

	watchdog_stop_on_unregister(&xen_wdt_dev);



	ret = devm_watchdog_register_device(&pdev->dev, &xen_wdt_dev);

	ret = devm_watchdog_register_device(dev, &xen_wdt_dev);

	if (ret) {

		dev_err(&pdev->dev, "cannot register watchdog device (%d)\n",

			ret);

		dev_err(dev, "cannot register watchdog device (%d)\n", ret);

		return ret;

	}



	dev_info(&pdev->dev, "initialized (timeout=%ds, nowayout=%d)\n",

	dev_info(dev, "initialized (timeout=%ds, nowayout=%d)\n",

		 xen_wdt_dev.timeout, nowayout);



	return 0;

CRA Git | Maintained and supported by SUSTech CRA and CCSE