Commit b8fb6406 authored Aug 02, 2019 by Nathan Chancellor Committed by David S. Miller Aug 06, 2019

net: mdio-octeon: Fix Kconfig warnings and build errors



After commit 171a9bae ("staging/octeon: Allow test build on
!MIPS"), the following combination of configs cause a few Kconfig
warnings and build errors (distilled from arm allyesconfig and Randy's
randconfig builds):

    CONFIG_NETDEVICES=y
    CONFIG_STAGING=y
    CONFIG_COMPILE_TEST=y

and CONFIG_OCTEON_ETHERNET as either a module or built-in.

WARNING: unmet direct dependencies detected for MDIO_OCTEON
  Depends on [n]: NETDEVICES [=y] && MDIO_DEVICE [=y] && MDIO_BUS [=y]
&& 64BIT [=n] && HAS_IOMEM [=y] && OF_MDIO [=n]
  Selected by [y]:
  - OCTEON_ETHERNET [=y] && STAGING [=y] && (CAVIUM_OCTEON_SOC ||
COMPILE_TEST [=y]) && NETDEVICES [=y]

In file included from ../drivers/net/phy/mdio-octeon.c:14:
../drivers/net/phy/mdio-cavium.h:111:36: error: implicit declaration of
function ‘writeq’; did you mean ‘writel’?
[-Werror=implicit-function-declaration]
  111 | #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr)
      |                                    ^~~~~~

CONFIG_64BIT is not strictly necessary if the proper readq/writeq
definitions are included from io-64-nonatomic-lo-hi.h.

CONFIG_OF_MDIO is not needed when CONFIG_COMPILE_TEST is enabled because
of commit f9dc9ac5 ("of/mdio: Add dummy functions in of_mdio.h.").

Fixes: 171a9bae ("staging/octeon: Allow test build on !MIPS")
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Mark Brown <broonie@kernel.org>
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 48e23311

drivers/net/phy/Kconfig

+2 −2

Original line number	Diff line number	Diff line
		@@ -172,8 +172,8 @@ config MDIO_MSCC_MIIM

		config MDIO_OCTEON
		tristate "Octeon and some ThunderX SOCs MDIO buses"
		depends on 64BIT
		depends on HAS_IOMEM && OF_MDIO
		depends on (64BIT && OF_MDIO) \|\| COMPILE_TEST
		depends on HAS_IOMEM
		select MDIO_CAVIUM
		help
		This module provides a driver for the Octeon and ThunderX MDIO

drivers/net/phy/mdio-cavium.h

+2 −0

Original line number	Diff line number	Diff line
		@@ -108,6 +108,8 @@ static inline u64 oct_mdio_readq(u64 addr)
		return cvmx_read_csr(addr);
		}
		#else
		#include <linux/io-64-nonatomic-lo-hi.h>

		#define oct_mdio_writeq(val, addr) writeq(val, (void *)addr)
		#define oct_mdio_readq(addr) readq((void *)addr)
		#endif

Admin message