Unverified Commit b8f94957 authored Oct 29, 2020 by Xu Wang Committed by Mark Brown Nov 05, 2020

ASoC: pxa: pxa-ssp: Remove redundant null check before clk_prepare_enable/clk_disable_unprepare



ecause clk_prepare_enable() and clk_disable_unprepare() already checked
NULL clock parameter, so the additional checks are unnecessary, just
remove them.

Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
Link: https://lore.kernel.org/r/20201029090104.29552-1-vulab@iscas.ac.cn


Signed-off-by: Mark Brown <broonie@kernel.org>

parent ec4177c8

sound/soc/pxa/pxa-ssp.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -99,7 +99,6 @@ static int pxa_ssp_startup(struct snd_pcm_substream *substream,
		pxa_ssp_disable(ssp);
		}

		if (priv->extclk)
		clk_prepare_enable(priv->extclk);

		dma = kzalloc(sizeof(struct snd_dmaengine_dai_dma_data), GFP_KERNEL);
		@@ -124,7 +123,6 @@ static void pxa_ssp_shutdown(struct snd_pcm_substream *substream,
		clk_disable_unprepare(ssp->clk);
		}

		if (priv->extclk)
		clk_disable_unprepare(priv->extclk);

		kfree(snd_soc_dai_get_dma_data(cpu_dai, substream));

Admin message