Commit b8eb4136 authored Jun 25, 2013 by Chad Dupuis Committed by James Bottomley Jul 08, 2013

[SCSI] qla2xxx: Do not take a second firmware dump when intentionally generating one.

When we are intentionally generating a firmware dump by executing the
MBC_GEN_SYSTEM_ERROR command, the command actually times out. The normal
course of action when a mailbox command times out is to take a firmware dump.
However, in this special case we do not want to do this since the
MBA_SYSTEM_ERR AEN already generates a firmware dump.

Signed-off-by: Chad Dupuis <chad.dupuis@qlogic.com>
Signed-off-by: Saurav Kashyap <saurav.kashyap@qlogic.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>

parent 8fbfe2d2

drivers/scsi/qla2xxx/qla_mbx.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -281,8 +281,10 @@ qla2x00_mailbox_command(scsi_qla_host_t vha, mbx_cmd_t mcp)

		/*
		* Attempt to capture a firmware dump for further analysis
		* of the current firmware state
		* of the current firmware state. We do not need to do this
		* if we are intentionally generating a dump.
		*/
		if (mcp->mb[0] != MBC_GEN_SYSTEM_ERROR)
		ha->isp_ops->fw_dump(vha, 0);

		rval = QLA_FUNCTION_TIMEOUT;

Admin message