Commit b8e6a15a authored Aug 23, 2014 by Markus Stockhausen Committed by NeilBrown Oct 14, 2014

md/raid5: fix init_stripe() inconsistencies



raid5: fix init_stripe() inconsistencies

1) remove_hash() is not necessary. We will only be called right after
   get_free_stripe(). There we have already a call to remove_hash().

2) Tracing prints out the sector of the freed stripe and not the sector
   that we want to initialize.

Signed-off-by: NeilBrown <neilb@suse.de>

parent c4796e21

drivers/md/raid5.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -531,9 +531,7 @@ static void init_stripe(struct stripe_head *sh, sector_t sector, int previous)
		BUG_ON(stripe_operations_active(sh));

		pr_debug("init_stripe called, stripe %llu\n",
		(unsigned long long)sh->sector);

		remove_hash(sh);
		(unsigned long long)sector);
		retry:
		seq = read_seqcount_begin(&conf->gen_lock);
		sh->generation = conf->generation - previous;

Admin message