Commit b8e69d51 authored Apr 20, 2015 by Matti Gottlieb Committed by Johannes Berg Apr 24, 2015

mac80211: force off channel transmission for public action frames



Currently while associated to an AP and sending a (public) action
frame to a different AP on the same channel, the action frame will
be sent like a regular tx frame without going off channel.

When power save is enabled this can cause problems, since the device
can go into power save and miss the response to the action frame
that is sent by the other AP.

Force off-channel transmission to avoid this issue in case
- HW offchannel is used,
- the user didn't forbid transmitting frames off channel
- the frame is not sent to the AP that we are associated with
  (if it is we assume the response would be bufferable)

Signed-off-by: Matti Gottlieb <matti.gottlieb@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
[reword commit message a bit]
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

parent b497de63

net/mac80211/cfg.c

+7 −1

Original line number	Diff line number	Diff line
		@@ -3343,8 +3343,14 @@ static int ieee80211_mgmt_tx(struct wiphy wiphy, struct wireless_dev wdev,
		break;
		case NL80211_IFTYPE_STATION:
		case NL80211_IFTYPE_P2P_CLIENT:
		if (!sdata->u.mgd.associated)
		sdata_lock(sdata);
		if (!sdata->u.mgd.associated \|\|
		(params->offchan && params->wait &&
		local->ops->remain_on_channel &&
		memcmp(sdata->u.mgd.associated->bssid,
		mgmt->bssid, ETH_ALEN)))
		need_offchan = true;
		sdata_unlock(sdata);
		break;
		case NL80211_IFTYPE_P2P_DEVICE:
		need_offchan = true;

Admin message