Commit b8cffc6a authored by Tejun Heo's avatar Tejun Heo Committed by Jeff Garzik
Browse files

libata: improve ata_std_prereset() 



This patch updates ata_std_prereset() as follows.

* Don't fail on phy resume failure.  Just whine and continue.  Failure
  from prereset makes libata abort whole reset sequence and give up
  the port, so prereset() should be best effort.  This is more
  important with the coming EH updates as prereset() will be called
  with shorter timeout.

* If ata_wait_ready() fails, whine and request hardreset instead.

Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
parent 9b89391c

drivers/ata/libata-core.c

+15 −7
Original line number Diff line number Diff line
@@ -3338,7 +3338,11 @@ static void ata_wait_spinup(struct ata_port *ap, unsigned long deadline) 
 *	@ap: ATA port to be reset

 *	@deadline: deadline jiffies for the operation

 *

 *	@ap is about to be reset.  Initialize it.

 *	@ap is about to be reset.  Initialize it.  Failure from

 *	prereset makes libata abort whole reset sequence and give up

 *	that port, so prereset should be best-effort.  It does its

 *	best to prepare for reset sequence but if things go wrong, it

 *	should just whine, not fail.

 *

 *	LOCKING:

 *	Kernel thread context (may sleep)
@@ -3368,19 +3372,23 @@ int ata_std_prereset(struct ata_port *ap, unsigned long deadline) 
	/* if SATA, resume phy */

	if (ap->cbl == ATA_CBL_SATA) {

		rc = sata_phy_resume(ap, timing, deadline);

		if (rc && rc != -EOPNOTSUPP) {

			/* phy resume failed */

		/* whine about phy resume failure but proceed */

		if (rc && rc != -EOPNOTSUPP)

			ata_port_printk(ap, KERN_WARNING, "failed to resume "

					"link for reset (errno=%d)\n", rc);

			return rc;

		}

	}



	/* Wait for !BSY if the controller can wait for the first D2H

	 * Reg FIS and we don't know that no device is attached.

	 */

	if (!(ap->flags & ATA_FLAG_SKIP_D2H_BSY) && !ata_port_offline(ap))

		ata_wait_ready(ap, deadline);

	if (!(ap->flags & ATA_FLAG_SKIP_D2H_BSY) && !ata_port_offline(ap)) {

		rc = ata_wait_ready(ap, deadline);

		if (rc) {

			ata_port_printk(ap, KERN_WARNING, "device not ready "

					"(errno=%d), forcing hardreset\n", rc);

			ehc->i.action |= ATA_EH_HARDRESET;

		}

	}



	return 0;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE