Commit b8c98ae4 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Greg Kroah-Hartman
Browse files

tty: synclink: avoid sleep_on race 



The four variants of the synclink driver use the same code in their
open() callback to wait for a port in process of being closed,
using interruptible_sleep_on, which is racy and going away soon.

Making things worse, these functions hold the BTM while doing so,
which means that if we ever enter this code path, we cannot actually
continue since the other thread that is in process of closing the
port can no longer get the BTM.

This addresses both issues by using wait_event_interruptible_tty()
instead.

Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.cz>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 591cee0a

drivers/char/pcmcia/synclink_cs.c

+2 −2
Original line number Diff line number Diff line
@@ -2511,8 +2511,8 @@ static int mgslpc_open(struct tty_struct *tty, struct file * filp) 


	/* If port is closing, signal caller to try again */

	if (tty_hung_up_p(filp) || port->flags & ASYNC_CLOSING){

		if (port->flags & ASYNC_CLOSING)

			interruptible_sleep_on(&port->close_wait);

		wait_event_interruptible_tty(tty, port->close_wait,

					     !(port->flags & ASYNC_CLOSING));

		retval = ((port->flags & ASYNC_HUP_NOTIFY) ?

			-EAGAIN : -ERESTARTSYS);

		goto cleanup;

drivers/tty/synclink.c

+2 −2
Original line number Diff line number Diff line
@@ -3404,8 +3404,8 @@ static int mgsl_open(struct tty_struct *tty, struct file * filp) 


	/* If port is closing, signal caller to try again */

	if (tty_hung_up_p(filp) || info->port.flags & ASYNC_CLOSING){

		if (info->port.flags & ASYNC_CLOSING)

			interruptible_sleep_on(&info->port.close_wait);

		wait_event_interruptible_tty(tty, info->port.close_wait,

				     !(info->port.flags & ASYNC_CLOSING));

		retval = ((info->port.flags & ASYNC_HUP_NOTIFY) ?

			-EAGAIN : -ERESTARTSYS);

		goto cleanup;

drivers/tty/synclink_gt.c

+2 −2
Original line number Diff line number Diff line
@@ -674,8 +674,8 @@ static int open(struct tty_struct *tty, struct file *filp) 


	/* If port is closing, signal caller to try again */

	if (tty_hung_up_p(filp) || info->port.flags & ASYNC_CLOSING){

		if (info->port.flags & ASYNC_CLOSING)

			interruptible_sleep_on(&info->port.close_wait);

		wait_event_interruptible_tty(tty, info->port.close_wait,

					     !(info->port.flags & ASYNC_CLOSING));

		retval = ((info->port.flags & ASYNC_HUP_NOTIFY) ?

			-EAGAIN : -ERESTARTSYS);

		goto cleanup;

drivers/tty/synclinkmp.c

+2 −2
Original line number Diff line number Diff line
@@ -754,8 +754,8 @@ static int open(struct tty_struct *tty, struct file *filp) 


	/* If port is closing, signal caller to try again */

	if (tty_hung_up_p(filp) || info->port.flags & ASYNC_CLOSING){

		if (info->port.flags & ASYNC_CLOSING)

			interruptible_sleep_on(&info->port.close_wait);

		wait_event_interruptible_tty(tty, info->port.close_wait,

					     !(info->port.flags & ASYNC_CLOSING));

		retval = ((info->port.flags & ASYNC_HUP_NOTIFY) ?

			-EAGAIN : -ERESTARTSYS);

		goto cleanup;

CRA Git | Maintained and supported by SUSTech CRA and CCSE