Commit b8c1c5da authored Jul 24, 2007 by Andrew Morton Committed by Linus Torvalds Jul 24, 2007

slab: correctly handle __GFP_ZERO



Use the correct local variable when calling into the page allocator.  Local
`flags' can have __GFP_ZERO set, which causes us to pass __GFP_ZERO into the
page allocator, possibly from illegal contexts.  The page allocator will later
do prep_zero_page()->kmap_atomic(..., KM_USER0) from irq contexts and will
then go BUG.

Cc: Mike Galbraith <efault@gmx.de>
Acked-by: Christoph Lameter <clameter@sgi.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 01e457cf

mm/slab.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2776,7 +2776,7 @@ static int cache_grow(struct kmem_cache *cachep,
		* 'nodeid'.
		*/
		if (!objp)
		objp = kmem_getpages(cachep, flags, nodeid);
		objp = kmem_getpages(cachep, local_flags, nodeid);
		if (!objp)
		goto failed;

Admin message