Commit b8c15839 authored May 14, 2020 by Guillaume Nault Committed by David S. Miller May 14, 2020

pppoe: only process PADT targeted at local interfaces



We don't want to disconnect a session because of a stray PADT arriving
while the interface is in promiscuous mode.
Furthermore, multicast and broadcast packets make no sense here, so
only PACKET_HOST is accepted.

Reported-by: David Balažic <xerces9@gmail.com>
Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Signed-off-by: Guillaume Nault <gnault@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent fd4a5177

drivers/net/ppp/pppoe.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -490,6 +490,9 @@ static int pppoe_disc_rcv(struct sk_buff skb, struct net_device dev,
		if (!skb)
		goto out;

		if (skb->pkt_type != PACKET_HOST)
		goto abort;

		if (!pskb_may_pull(skb, sizeof(struct pppoe_hdr)))
		goto abort;

Admin message