Commit b8b27752 authored May 09, 2019 by Oliver Neukum Committed by David S. Miller May 09, 2019

aqc111: fix endianness issue in aqc111_change_mtu



If the MTU is large enough, the first write to the device
is just repeated. On BE architectures, however, the first
word of the command will be swapped a second time and garbage
will be written. Avoid that.

Signed-off-by: Oliver Neukum <oneukum@suse.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 873017af

drivers/net/usb/aqc111.c

+2 −0

Original line number	Original line	Diff line number	Diff line
	@@ -453,6 +453,8 @@ static int aqc111_change_mtu(struct net_device *net, int new_mtu)
	reg16 = 0x1420;		reg16 = 0x1420;
	else if (dev->net->mtu <= 16334)		else if (dev->net->mtu <= 16334)
	reg16 = 0x1A20;		reg16 = 0x1A20;
			else
			return 0;

	aqc111_write16_cmd(dev, AQ_ACCESS_MAC, SFR_PAUSE_WATERLVL_LOW,		aqc111_write16_cmd(dev, AQ_ACCESS_MAC, SFR_PAUSE_WATERLVL_LOW,
	2, &reg16);		2, &reg16);

Admin message