Commit b8aa09fd authored by Rusty Russell's avatar Rusty Russell Committed by James Morris
Browse files

apparmor: fix module parameter handling 



The 'aabool' wrappers actually pass off to the 'bool' parse functions,
so you should use the same check function.  Similarly for aauint and
uint.

(Note that 'bool' module parameters also allow 'int', which is why you
got away with this, but that's changing very soon.)

Cc: linux-security-module@vger.kernel.org
Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
Acked-by: default avatarJohn Johansen <john.johansen@canonical.com>
Signed-off-by: default avatarJames Morris <jmorris@namei.org>
parent 735e93c7

security/apparmor/lsm.c

+3 −3
Original line number Diff line number Diff line
@@ -671,7 +671,7 @@ static struct security_operations apparmor_ops = { 


static int param_set_aabool(const char *val, const struct kernel_param *kp);

static int param_get_aabool(char *buffer, const struct kernel_param *kp);

#define param_check_aabool(name, p) __param_check(name, p, int)

#define param_check_aabool param_check_bool

static struct kernel_param_ops param_ops_aabool = {

	.set = param_set_aabool,

	.get = param_get_aabool
@@ -679,7 +679,7 @@ static struct kernel_param_ops param_ops_aabool = { 


static int param_set_aauint(const char *val, const struct kernel_param *kp);

static int param_get_aauint(char *buffer, const struct kernel_param *kp);

#define param_check_aauint(name, p) __param_check(name, p, int)

#define param_check_aauint param_check_uint

static struct kernel_param_ops param_ops_aauint = {

	.set = param_set_aauint,

	.get = param_get_aauint
@@ -687,7 +687,7 @@ static struct kernel_param_ops param_ops_aauint = { 


static int param_set_aalockpolicy(const char *val, const struct kernel_param *kp);

static int param_get_aalockpolicy(char *buffer, const struct kernel_param *kp);

#define param_check_aalockpolicy(name, p) __param_check(name, p, int)

#define param_check_aalockpolicy param_check_bool

static struct kernel_param_ops param_ops_aalockpolicy = {

	.set = param_set_aalockpolicy,

	.get = param_get_aalockpolicy

CRA Git | Maintained and supported by SUSTech CRA and CCSE