Commit b89e242e authored Nov 09, 2018 by Eric Farman Committed by Cornelia Huck Nov 13, 2018

s390/cio: Fix cleanup when unsupported IDA format is used



Direct returns from within a loop are rude, but it doesn't mean it gets
to avoid releasing the memory acquired beforehand.

Signed-off-by: Eric Farman <farman@linux.ibm.com>
Message-Id: <20181109023937.96105-3-farman@linux.ibm.com>
Reviewed-by: Farhan Ali <alifm@linux.ibm.com>
Reviewed-by: Pierre Morel <pmorel@linux.ibm.com>
Acked-by: Halil Pasic <pasic@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>

parent 806212f9

drivers/s390/cio/vfio_ccw_cp.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -387,8 +387,10 @@ static int ccwchain_calc_length(u64 iova, struct channel_program *cp)
		* orb specified one of the unsupported formats, we defer
		* checking for IDAWs in unsupported formats to here.
		*/
		if ((!cp->orb.cmd.c64 \|\| cp->orb.cmd.i2k) && ccw_is_idal(ccw))
		if ((!cp->orb.cmd.c64 \|\| cp->orb.cmd.i2k) && ccw_is_idal(ccw)) {
		kfree(p);
		return -EOPNOTSUPP;
		}

		if ((!ccw_is_chain(ccw)) && (!ccw_is_tic(ccw)))
		break;

Admin message