vfs: show_vfsstat: remove redundant initialization and check of error code (b896fb35) · Commits · 戴 / test

As err variable is now always checked right after each assignment, its initialization is redundant and could be safely removed. For the same reason, the last check of err is also redundant and could be removed as well. Signed-off-by:

Dmitry V. Levin <ldv@altlinux.org> Signed-off-by:

Al Viro <viro@zeniv.linux.org.uk>

fs/proc_namespace.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -193,7 +193,7 @@ static int show_vfsstat(struct seq_file m, struct vfsmount mnt)
		struct mount *r = real_mount(mnt);
		struct path mnt_path = { .dentry = mnt->mnt_root, .mnt = mnt };
		struct super_block *sb = mnt_path.dentry->d_sb;
		int err = 0;
		int err;

		/* device */
		if (sb->s_op->show_devname) {
		@@ -222,7 +222,6 @@ static int show_vfsstat(struct seq_file m, struct vfsmount mnt)
		/* optional statistics */
		if (sb->s_op->show_stats) {
		seq_putc(m, ' ');
		if (!err)
		err = sb->s_op->show_stats(m, mnt_path.dentry);
		}

Admin message