Commit b8922125 authored Jul 09, 2016 by Xunlei Pang Committed by Ingo Molnar Aug 10, 2016

sched/fair: Fix typo in sync_throttle()



We should update cfs_rq->throttled_clock_task, not
pcfs_rq->throttle_clock_task.

The effects of this bug was probably occasionally erratic
group scheduling, particularly in cgroups-intense workloads.

Signed-off-by: Xunlei Pang <xlpang@redhat.com>
[ Added changelog. ]
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Fixes: 55e16d30 ("sched/fair: Rework throttle_count sync")
Link: http://lkml.kernel.org/r/1468050862-18864-1-git-send-email-xlpang@redhat.com


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent a23eadfa

kernel/sched/fair.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -4269,7 +4269,7 @@ static void sync_throttle(struct task_group *tg, int cpu)
		pcfs_rq = tg->parent->cfs_rq[cpu];

		cfs_rq->throttle_count = pcfs_rq->throttle_count;
		pcfs_rq->throttled_clock_task = rq_clock_task(cpu_rq(cpu));
		cfs_rq->throttled_clock_task = rq_clock_task(cpu_rq(cpu));
		}

		/* conditionally throttle active cfs_rq's from put_prev_entity() */

Admin message