Commit b866203d authored Jun 20, 2017 by Zach Brown Committed by David S. Miller Jun 22, 2017

net/phy: micrel: configure intterupts after autoneg workaround



The commit ("net/phy: micrel: Add workaround for bad autoneg") fixes an
autoneg failure case by resetting the hardware. This turns off
intterupts. Things will work themselves out if the phy polls, as it will
figure out it's state during a poll. However if the phy uses only
intterupts, the phy will stall, since interrupts are off. This patch
fixes the issue by calling config_intr after resetting the phy.

Fixes: d2fd719b ("net/phy: micrel: Add workaround for bad autoneg ")
Signed-off-by: Zach Brown <zach.brown@ni.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 48b6bbef

drivers/net/phy/micrel.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -619,6 +619,8 @@ static int ksz9031_read_status(struct phy_device *phydev)
		if ((regval & 0xFF) == 0xFF) {
		phy_init_hw(phydev);
		phydev->link = 0;
		if (phydev->drv->config_intr && phy_interrupt_is_valid(phydev))
		phydev->drv->config_intr(phydev);
		}

		return 0;

Admin message