Commit b85f6b60 authored Oct 04, 2019 by Arun Kumar Neelakantam Committed by Bjorn Andersson Oct 16, 2019

rpmsg: glink: Fix reuse intents memory leak issue



Memory allocated for re-usable intents are not freed during channel
cleanup which causes memory leak in system.

Check and free all re-usable memory to avoid memory leak.

Fixes: 933b45da ("rpmsg: glink: Add support for TX intents")
Cc: stable@vger.kernel.org
Acked-By: Chris Lew <clew@codeaurora.org>
Tested-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: Arun Kumar Neelakantam <aneela@codeaurora.org>
Reported-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

parent 4623e8bf

drivers/rpmsg/qcom_glink_native.c

+9 −0

Original line number	Diff line number	Diff line
		@@ -241,10 +241,19 @@ static void qcom_glink_channel_release(struct kref *ref)
		{
		struct glink_channel *channel = container_of(ref, struct glink_channel,
		refcount);
		struct glink_core_rx_intent *tmp;
		unsigned long flags;
		int iid;

		spin_lock_irqsave(&channel->intent_lock, flags);
		idr_for_each_entry(&channel->liids, tmp, iid) {
		kfree(tmp->data);
		kfree(tmp);
		}
		idr_destroy(&channel->liids);

		idr_for_each_entry(&channel->riids, tmp, iid)
		kfree(tmp);
		idr_destroy(&channel->riids);
		spin_unlock_irqrestore(&channel->intent_lock, flags);

Admin message