[PATCH] for_each_possible_cpu: ppc (b848e0a0) · Commits · 戴 / test

for_each_cpu() actually iterates across all possible CPUs. We've had mistakes in the past where people were using for_each_cpu() where they should have been iterating across only online or present CPUs. This is inefficient and possibly buggy. We're renaming for_each_cpu() to for_each_possible_cpu() to avoid this in the future. This patch replaces for_each_cpu with for_each_possible_cpu. Signed-off-by:

KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> Signed-off-by:

Andrew Morton <akpm@osdl.org> Signed-off-by:

Paul Mackerras <paulus@samba.org>

arch/ppc/kernel/setup.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -474,7 +474,7 @@ int __init ppc_init(void)
	if ( ppc_md.progress ) ppc_md.progress(" ", 0xffff);		if ( ppc_md.progress ) ppc_md.progress(" ", 0xffff);

	/* register CPU devices */		/* register CPU devices */
	for_each_cpu(i)		for_each_possible_cpu(i)
	register_cpu(&cpu_devices[i], i, NULL);		register_cpu(&cpu_devices[i], i, NULL);

	/* call platform init */		/* call platform init */

arch/ppc/kernel/smp.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -311,7 +311,7 @@ void __init smp_prepare_cpus(unsigned int max_cpus)
	/* Backup CPU 0 state */		/* Backup CPU 0 state */
	__save_cpu_setup();		__save_cpu_setup();

	for_each_cpu(cpu) {		for_each_possible_cpu(cpu) {
	if (cpu == smp_processor_id())		if (cpu == smp_processor_id())
	continue;		continue;
	/* create a process for the processor */		/* create a process for the processor */

Admin message