Commit b81e5ddb authored Jun 09, 2017 by Takashi Sakamoto Committed by Takashi Iwai Jun 08, 2017

ALSA: pcm: use helper functions to check whether parameters are determined



A commit 8bea869c ("ALSA: PCM midlevel: improve fifo_size handling")
allows drivers to implement calculation of fifo size in parameter
structure. This calculation runs only when two of the other parameters
have single value.

In ALSA PCM core, there're some helper functions for the case. This commit
applies the functions instead of value comparison.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent a1c06e39

sound/core/pcm_native.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -443,8 +443,7 @@ int snd_pcm_hw_refine(struct snd_pcm_substream *substream,
		if (!params->fifo_size) {
		m = hw_param_mask(params, SNDRV_PCM_HW_PARAM_FORMAT);
		i = hw_param_interval(params, SNDRV_PCM_HW_PARAM_CHANNELS);
		if (snd_mask_min(m) == snd_mask_max(m) &&
		snd_interval_min(i) == snd_interval_max(i)) {
		if (snd_mask_single(m) && snd_interval_single(i)) {
		err = substream->ops->ioctl(substream,
		SNDRV_PCM_IOCTL1_FIFO_SIZE, params);
		if (err < 0)

Admin message