Commit b81b7291 authored Jul 21, 2017 by Sakari Ailus Committed by Rafael J. Wysocki Jul 22, 2017

ACPI: Use IS_ERR_OR_NULL() instead of non-NULL check in is_acpi_data_node()



The is_acpi_data_node() function takes a struct fwnode_handle pointer as
its argument. The validity of the pointer is first checked. Extend the
check to cover error values as is done by similar is_acpi_node() and
is_acpi_device_node() functions.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent 5771a8c0

include/acpi/acpi_bus.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -414,7 +414,7 @@ static inline struct acpi_device to_acpi_device_node(struct fwnode_handle fwno

		static inline bool is_acpi_data_node(struct fwnode_handle *fwnode)
		{
		return fwnode && fwnode->type == FWNODE_ACPI_DATA;
		return !IS_ERR_OR_NULL(fwnode) && fwnode->type == FWNODE_ACPI_DATA;
		}

		static inline struct acpi_data_node to_acpi_data_node(struct fwnode_handle fwnode)

Admin message