Commit b7fd1edd authored by Constantine Gavrilov's avatar Constantine Gavrilov Committed by Linus Torvalds
Browse files

[PATCH] x86: fix sigaddset() inline asm memory constraint 



Due to incomplete memory constraints, gcc would miscompile code with
sigaddset on i386 if sig arg was const.

A quote form Jakub to make the issue clear:

 "You need either
	__asm__("btsl %1,%0" : "+m"(*set) : "Ir"(_sig-1) : "cc");
  or
	__asm__("btsl %1,%0" : "=m"(*set) : "Ir"(_sig-1), "m"(*set) : "cc");
  because the btsl instruction doesn't just set the memory to some
  value, but needs to read its previous content as well.  If you don't
  tell that fact to GCC, GCC is of course free to optimize as if the asm
  was just setting the value and not depended on the previous value."

Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 3b26b110

include/asm-i386/signal.h

+27 −4
Original line number Diff line number Diff line
@@ -159,14 +159,37 @@ typedef struct sigaltstack { 


#define __HAVE_ARCH_SIG_BITOPS



static __inline__ void sigaddset(sigset_t *set, int _sig)

#define sigaddset(set,sig)                 \

	(__builtin_constant_p(sig) ?       \

	__const_sigaddset((set),(sig)) :   \

	__gen_sigaddset((set),(sig)))



static __inline__ void __gen_sigaddset(sigset_t *set, int _sig)

{

	__asm__("btsl %1,%0" : "=m"(*set) : "Ir"(_sig - 1) : "cc");

	__asm__("btsl %1,%0" : "+m"(*set) : "Ir"(_sig - 1) : "cc");

}



static __inline__ void sigdelset(sigset_t *set, int _sig)

static __inline__ void __const_sigaddset(sigset_t *set, int _sig)

{

	__asm__("btrl %1,%0" : "=m"(*set) : "Ir"(_sig - 1) : "cc");

	unsigned long sig = _sig - 1;

	set->sig[sig / _NSIG_BPW] |= 1 << (sig % _NSIG_BPW);

}



#define sigdelset(set,sig)                 \

	(__builtin_constant_p(sig) ?       \

	__const_sigdelset((set),(sig)) :   \

	__gen_sigdelset((set),(sig)))





static __inline__ void __gen_sigdelset(sigset_t *set, int _sig)

{

	__asm__("btrl %1,%0" : "+m"(*set) : "Ir"(_sig - 1) : "cc");

}



static __inline__ void __const_sigaddset(sigset_t *set, int _sig)

{

	unsigned long sig = _sig - 1;

	set->sig[sig / _NSIG_BPW] &= ~(1 << (sig % _NSIG_BPW));

}



static __inline__ int __const_sigismember(sigset_t *set, int _sig)

CRA Git | Maintained and supported by SUSTech CRA and CCSE