Commit b7ec41da authored Jul 22, 2020 by Horia Geantă Committed by Herbert Xu Jul 31, 2020

crypto: caam/qi2 - create ahash shared descriptors only once



For keyed hash algorithms, shared descriptors are currently generated
twice:
-at tfm initialization time, in cra_init() callback
-in setkey() callback

Since it's mandatory to call setkey() for keyed algorithms, drop the
generation in cra_init().

This is similar to the change in caamhash (caam/jr top-level library)
commit 9a2537d0 ("crypto: caam - create ahash shared descriptors only once")

Signed-off-by: Horia Geantă <horia.geanta@nxp.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent d9f2d010

drivers/crypto/caam/caamalg_qi2.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -4500,7 +4500,11 @@ static int caam_hash_cra_init(struct crypto_tfm *tfm)
		crypto_ahash_set_reqsize(__crypto_ahash_cast(tfm),
		sizeof(struct caam_hash_state));

		return ahash_set_sh_desc(ahash);
		/*
		* For keyed hash algorithms shared descriptors
		* will be created later in setkey() callback
		*/
		return alg->setkey ? 0 : ahash_set_sh_desc(ahash);
		}

		static void caam_hash_cra_exit(struct crypto_tfm *tfm)

Admin message