Commit b7ea3c41 authored Jul 03, 2013 by Mel Gorman Committed by Linus Torvalds Jul 03, 2013

mm: vmscan: check if kswapd should writepage once per pgdat scan



Currently kswapd checks if it should start writepage as it shrinks each
zone without taking into consideration if the zone is balanced or not.
This is not wrong as such but it does not make much sense either.  This
patch checks once per pgdat scan if kswapd should be writing pages.

Signed-off-by: Mel Gorman <mgorman@suse.de>
Reviewed-by: Michal Hocko <mhocko@suse.cz>
Acked-by: Rik van Riel <riel@redhat.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Jiri Slaby <jslaby@suse.cz>
Cc: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>
Tested-by: Zlatko Calusic <zcalusic@bitsync.net>
Cc: dormando <dormando@rydia.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 283aba9f

mm/vmscan.c

+7 −7

Original line number	Diff line number	Diff line
		@@ -2852,6 +2852,13 @@ static unsigned long balance_pgdat(pg_data_t *pgdat, int order,
		pgdat_needs_compaction = false;
		}

		/*
		* If we're getting trouble reclaiming, start doing writepage
		* even in laptop mode.
		*/
		if (sc.priority < DEF_PRIORITY - 2)
		sc.may_writepage = 1;

		/*
		* Now scan the zone in the dma->highmem direction, stopping
		* at the last zone which needs scanning.
		@@ -2923,13 +2930,6 @@ static unsigned long balance_pgdat(pg_data_t *pgdat, int order,
		raise_priority = false;
		}

		/*
		* If we're getting trouble reclaiming, start doing
		* writepage even in laptop mode.
		*/
		if (sc.priority < DEF_PRIORITY - 2)
		sc.may_writepage = 1;

		if (zone->all_unreclaimable) {
		if (end_zone && end_zone == i)
		end_zone--;

Admin message