Commit b7e768b7 authored Sep 24, 2018 by Nathan Chancellor Committed by David Howells Nov 30, 2018

cachefiles: Explicitly cast enumerated type in put_object



Clang warns when one enumerated type is implicitly converted to another.

fs/cachefiles/namei.c:247:50: warning: implicit conversion from
enumeration type 'enum cachefiles_obj_ref_trace' to different
enumeration type 'enum fscache_obj_ref_trace' [-Wenum-conversion]
        cache->cache.ops->put_object(&xobject->fscache,
cachefiles_obj_put_wait_retry);

Silence this warning by explicitly casting to fscache_obj_ref_trace,
which is also done in put_object.

Reported-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: David Howells <dhowells@redhat.com>

parent c5a94f43

fs/cachefiles/namei.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -244,11 +244,13 @@ wait_for_old_object:

		ASSERT(!test_bit(CACHEFILES_OBJECT_ACTIVE, &xobject->flags));

		cache->cache.ops->put_object(&xobject->fscache, cachefiles_obj_put_wait_retry);
		cache->cache.ops->put_object(&xobject->fscache,
		(enum fscache_obj_ref_trace)cachefiles_obj_put_wait_retry);
		goto try_again;

		requeue:
		cache->cache.ops->put_object(&xobject->fscache, cachefiles_obj_put_wait_timeo);
		cache->cache.ops->put_object(&xobject->fscache,
		(enum fscache_obj_ref_trace)cachefiles_obj_put_wait_timeo);
		_leave(" = -ETIMEDOUT");
		return -ETIMEDOUT;
		}

Admin message