Commit b7d373c5 authored Oct 08, 2018 by Quentin Schulz Committed by David S. Miller Oct 08, 2018

net: phy: mscc: remove unneeded parenthesis



The == operator precedes the || operator, so we can remove the
parenthesis around (a == b) || (c == d).

The condition is rather explicit and short so removing the parenthesis
definitely does not make it harder to read.

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Quentin Schulz <quentin.schulz@bootlin.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 96dae01f

drivers/net/phy/mscc.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -300,7 +300,7 @@ static int vsc85xx_mdix_set(struct phy_device *phydev, u8 mdix)
		u16 reg_val;

		reg_val = phy_read(phydev, MSCC_PHY_BYPASS_CONTROL);
		if ((mdix == ETH_TP_MDI) \|\| (mdix == ETH_TP_MDI_X)) {
		if (mdix == ETH_TP_MDI \|\| mdix == ETH_TP_MDI_X) {
		reg_val \|= (DISABLE_PAIR_SWAP_CORR_MASK \|
		DISABLE_POLARITY_CORR_MASK \|
		DISABLE_HP_AUTO_MDIX_MASK);

Admin message