Commit b7cd1b13 authored Mar 06, 2017 by Bartosz Golaszewski Committed by Mark Brown Mar 07, 2017

regulator: core: use snprintf() instead of scnprintf()



When creating the link to the device sysfs entry, the regulator core
calls scnprintf() and then checks if the returned value is greater or
equal than the buffer size.

The former can never happen as scnprintf() returns the number of bytes
that were actually written to the buffer, not the bytes that *would*
have been written.

Use the right function in this case: snprintf().

Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent c1ae3cfa

drivers/regulator/core.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1326,7 +1326,7 @@ static struct regulator create_regulator(struct regulator_dev rdev,
		regulator->dev = dev;

		/* Add a link to the device sysfs entry */
		size = scnprintf(buf, REG_STR_SIZE, "%s-%s",
		size = snprintf(buf, REG_STR_SIZE, "%s-%s",
		dev->kobj.name, supply_name);
		if (size >= REG_STR_SIZE)
		goto overflow_err;

Admin message