Commit b753af31 authored Mar 02, 2015 by Eric W. Biederman Committed by David S. Miller Mar 02, 2015

rose: Set the destination address in rose_header



Not setting the destination address is a bug that I suspect causes no
problems today, as only the arp code seems to call dev_hard_header and
the description I have of rose is that it is expected to be used with a
static neigbour table.

I have derived the offset and the length of the rose destination address
from rose_rebuild_header where arp_find calls neigh_ha_snapshot to set
the destination address.

Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-hams@vger.kernel.org
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent e18dbd05

net/rose/rose_dev.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -41,6 +41,9 @@ static int rose_header(struct sk_buff skb, struct net_device dev,
		{
		unsigned char *buff = skb_push(skb, ROSE_MIN_LEN + 2);

		if (daddr)
		memcpy(buff + 7, daddr, dev->addr_len);

		*buff++ = ROSE_GFI \| ROSE_Q_BIT;
		*buff++ = 0x00;
		*buff++ = ROSE_DATA;

Admin message