Commit b74a2f09 authored Mar 16, 2007 by suzuki Committed by Linus Torvalds Mar 16, 2007

[PATCH] fix rescan_partitions to return errors properly



The only error code which comes from the partition checkers is -1, when
they finds an EIO.  As per the discussion, ENOMEM values were ignored,
as they might scare the users.

So, with the current code, we end up returning -1 and not EIO for the
ioctl() calls.  Which doesn't give any clue to the user of what went
wrong.

Signed-off-by: Suzuki K P <suzuki@in.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent b257bc05

fs/partitions/check.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -541,7 +541,7 @@ int rescan_partitions(struct gendisk disk, struct block_device bdev)
		if (!get_capacity(disk) \|\| !(state = check_partition(disk, bdev)))
		return 0;
		if (IS_ERR(state)) /* I/O error reading the partition table */
		return PTR_ERR(state);
		return -EIO;
		for (p = 1; p < state->limit; p++) {
		sector_t size = state->parts[p].size;
		sector_t from = state->parts[p].from;

Admin message