HID: elan: Fix memleak in elan_input_configured (b7429ea5) · Commits · 戴 / test

When input_mt_init_slots() fails, input should be freed to prevent memleak. When input_register_device() fails, we should call input_mt_destroy_slots() to free memory allocated by input_mt_init_slots(). Signed-off-by:

Dinghao Liu <dinghao.liu@zju.edu.cn> Signed-off-by:

Jiri Kosina <jkosina@suse.cz>

drivers/hid/hid-elan.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -188,6 +188,7 @@ static int elan_input_configured(struct hid_device hdev, struct hid_input hi)
		ret = input_mt_init_slots(input, ELAN_MAX_FINGERS, INPUT_MT_POINTER);
		if (ret) {
		hid_err(hdev, "Failed to init elan MT slots: %d\n", ret);
		input_free_device(input);
		return ret;
		}

		@@ -198,6 +199,7 @@ static int elan_input_configured(struct hid_device hdev, struct hid_input hi)
		if (ret) {
		hid_err(hdev, "Failed to register elan input device: %d\n",
		ret);
		input_mt_destroy_slots(input);
		input_free_device(input);
		return ret;
		}

Admin message