Commit b73df17e authored by Brian Foster's avatar Brian Foster Committed by Darrick J. Wong
Browse files

xfs: open code insert range extent split helper 



The insert range operation currently splits the extent at the target
offset in a separate transaction and lock cycle from the one that
shifts extents. In preparation for reworking insert range into an
atomic operation, lift the code into the caller so it can be easily
condensed to a single rolling transaction and lock cycle and
eliminate the helper. No functional changes.

Signed-off-by: default avatarBrian Foster <bfoster@redhat.com>
Reviewed-by: default avatarAllison Collins <allison.henderson@oracle.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
parent daebba1b

fs/xfs/libxfs/xfs_bmap.c

+2 −30
Original line number Diff line number Diff line
@@ -6025,8 +6025,8 @@ del_cursor: 
 * @split_fsb is a block where the extents is split.  If split_fsb lies in a

 * hole or the first block of extents, just return 0.

 */

STATIC int

xfs_bmap_split_extent_at(

int

xfs_bmap_split_extent(

	struct xfs_trans	*tp,

	struct xfs_inode	*ip,

	xfs_fileoff_t		split_fsb)
@@ -6142,34 +6142,6 @@ del_cursor: 
	return error;

}



int

xfs_bmap_split_extent(

	struct xfs_inode        *ip,

	xfs_fileoff_t           split_fsb)

{

	struct xfs_mount        *mp = ip->i_mount;

	struct xfs_trans        *tp;

	int                     error;



	error = xfs_trans_alloc(mp, &M_RES(mp)->tr_write,

			XFS_DIOSTRAT_SPACE_RES(mp, 0), 0, 0, &tp);

	if (error)

		return error;



	xfs_ilock(ip, XFS_ILOCK_EXCL);

	xfs_trans_ijoin(tp, ip, XFS_ILOCK_EXCL);



	error = xfs_bmap_split_extent_at(tp, ip, split_fsb);

	if (error)

		goto out;



	return xfs_trans_commit(tp);



out:

	xfs_trans_cancel(tp);

	return error;

}



/* Deferred mapping is only for real extents in the data fork. */

static bool

xfs_bmap_is_update_needed(

fs/xfs/libxfs/xfs_bmap.h

+2 −1
Original line number Diff line number Diff line
@@ -222,7 +222,8 @@ int xfs_bmap_can_insert_extents(struct xfs_inode *ip, xfs_fileoff_t off, 
int	xfs_bmap_insert_extents(struct xfs_trans *tp, struct xfs_inode *ip,

		xfs_fileoff_t *next_fsb, xfs_fileoff_t offset_shift_fsb,

		bool *done, xfs_fileoff_t stop_fsb);

int	xfs_bmap_split_extent(struct xfs_inode *ip, xfs_fileoff_t split_offset);

int	xfs_bmap_split_extent(struct xfs_trans *tp, struct xfs_inode *ip,

		xfs_fileoff_t split_offset);

int	xfs_bmapi_reserve_delalloc(struct xfs_inode *ip, int whichfork,

		xfs_fileoff_t off, xfs_filblks_t len, xfs_filblks_t prealloc,

		struct xfs_bmbt_irec *got, struct xfs_iext_cursor *cur,

fs/xfs/xfs_bmap_util.c

+13 −1
Original line number Diff line number Diff line
@@ -1151,7 +1151,19 @@ xfs_insert_file_space( 
	 * is not the starting block of extent, we need to split the extent at

	 * stop_fsb.

	 */

	error = xfs_bmap_split_extent(ip, stop_fsb);

	error = xfs_trans_alloc(mp, &M_RES(mp)->tr_write,

			XFS_DIOSTRAT_SPACE_RES(mp, 0), 0, 0, &tp);

	if (error)

		return error;



	xfs_ilock(ip, XFS_ILOCK_EXCL);

	xfs_trans_ijoin(tp, ip, XFS_ILOCK_EXCL);



	error = xfs_bmap_split_extent(tp, ip, stop_fsb);

	if (error)

		goto out_trans_cancel;



	error = xfs_trans_commit(tp);

	if (error)

		return error;

CRA Git | Maintained and supported by SUSTech CRA and CCSE