Commit b7283d5a authored by Alexander Shishkin's avatar Alexander Shishkin Committed by Greg Kroah-Hartman
Browse files

usb: chipidea: remove unneeded NULL check



As reported by Dan Carpenter, there is a NULL check in udc_start() that
follows a dereference of the pointer that's being checked. However, at
that point udc pointer shouldn't ever be NULL and if it is, the dereference
should cause an oops.

Signed-off-by: default avatarAlexander Shishkin <alexander.shishkin@linux.intel.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarFelipe Balbi <balbi@ti.com>
Signed-off-by: default avatarRichard Zhao <richard.zhao@freescale.com>
Acked-by: default avatarMarek Vasut <marex@denx.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3d97ff63
Loading
Loading
Loading
Loading
+0 −3
Original line number Diff line number Diff line
@@ -1648,9 +1648,6 @@ static int udc_start(struct ci13xxx *udc)
	struct device *dev = udc->dev;
	int retval = 0;

	if (!udc)
		return -EINVAL;

	spin_lock_init(&udc->lock);

	udc->gadget.ops          = &usb_gadget_ops;