Commit b718f91c authored Aug 01, 2007 by Christoph Lameter Committed by Tony Luck Aug 01, 2007

[IA64] ITC: Reduce rating for ITC clock if ITCs are drifty



Make sure to reduce the rating of the ITC clock if ITCs are drifty. If they
are drifting then we have not synchronized the ITC values, nor are we doing
the jitter compensation (useless since drift may increase the differentials
arbitrarily).

Without this patch it is possible that the ITC clock becomes selected as
the system clock on systems with drifty ITCs which will result in
nanosleep hanging.

One can still select the itc clock manually on such systems via

clocksource=itc

(Produces nice hangs on SGI Altix.)

Signed-off-by: Christoph Lameter <clameter@sgi.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>

parent 40d48575

arch/ia64/kernel/time.c

+15 −1

Original line number	Diff line number	Diff line
		@@ -240,7 +240,21 @@ ia64_init_itm (void)
		if (!nojitter)
		itc_jitter_data.itc_jitter = 1;
		#endif
		}
		} else
		/*
		* ITC is drifty and we have not synchronized the ITCs in smpboot.c.
		* ITC values may fluctuate significantly between processors.
		* Clock should not be used for hrtimers. Mark itc as only
		* useful for boot and testing.
		*
		* Note that jitter compensation is off! There is no point of
		* synchronizing ITCs since they may be large differentials
		* that change over time.
		*
		* The only way to fix this would be to repeatedly sync the
		* ITCs. Until that time we have to avoid ITC.
		*/
		clocksource_itc.rating = 50;

		/* Setup the CPU local timer tick */
		ia64_cpu_local_tick();

Admin message