i2c: bcm2835: Simplify with dev_err_probe() (b713aa86) · Commits · 戴 / test

Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and the error value gets printed. Signed-off-by:

drivers/i2c/busses/i2c-bcm2835.c

+3 −5

Original line number	Diff line number	Diff line
		@@ -421,11 +421,9 @@ static int bcm2835_i2c_probe(struct platform_device *pdev)
		return PTR_ERR(i2c_dev->regs);

		mclk = devm_clk_get(&pdev->dev, NULL);
		if (IS_ERR(mclk)) {
		if (PTR_ERR(mclk) != -EPROBE_DEFER)
		dev_err(&pdev->dev, "Could not get clock\n");
		return PTR_ERR(mclk);
		}
		if (IS_ERR(mclk))
		return dev_err_probe(&pdev->dev, PTR_ERR(mclk),
		"Could not get clock\n");

		i2c_dev->bus_clk = bcm2835_i2c_register_div(&pdev->dev, mclk, i2c_dev);