Commit b6f3a40c authored Feb 07, 2014 by Tim Smith Committed by David Howells Feb 07, 2014

af_rxrpc: Prevent RxRPC peers from ABORT-storming one another

When an ABORT is sent, aborting a connection, the sender quite reasonably
forgets about the connection. If another frame is received, another ABORT
will be sent. When the receiver gets it, it no longer applies to an extant
connection, so an ABORT is sent, and so on...

Prevent this by never sending a rejection for an ABORT packet.

Signed-off-by: Tim Smith <tim@electronghost.co.uk>
Signed-off-by: David Howells <dhowells@redhat.com>

parent 8961749e

net/rxrpc/ar-input.c

+8 −4

Original line number	Diff line number	Diff line
		@@ -606,8 +606,10 @@ dead_call:
		}

		_debug("dead call");
		if (sp->hdr.type != RXRPC_PACKET_TYPE_ABORT) {
		skb->priority = RX_CALL_DEAD;
		rxrpc_reject_packet(conn->trans->local, skb);
		}
		goto done;

		/* resend last packet of a completed call
		@@ -790,8 +792,10 @@ cant_route_call:
		skb->priority = RX_CALL_DEAD;
		}

		_debug("reject");
		if (sp->hdr.type != RXRPC_PACKET_TYPE_ABORT) {
		_debug("reject type %d",sp->hdr.type);
		rxrpc_reject_packet(local, skb);
		}
		rxrpc_put_local(local);
		_leave(" [no call]");
		return;

Admin message