Commit b6f15f82 authored by Alexander Duyck's avatar Alexander Duyck Committed by David S. Miller
Browse files

fib_trie: Fix regression in handling of inflate/halve failure 



When I updated the code to address a possible null pointer dereference in
resize I ended up reverting an exception handling fix for the suffix length
in the event that inflate or halve failed.  This change is meant to correct
that by reverting the earlier fix and instead simply getting the parent
again after inflate has been completed to avoid the possible null pointer
issue.

Fixes: ddb4b9a1 ("fib_trie: Address possible NULL pointer dereference in resize")
Signed-off-by: default avatarAlexander Duyck <alexander.h.duyck@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9cde9450

net/ipv4/fib_trie.c

+9 −4
Original line number Diff line number Diff line
@@ -830,7 +830,7 @@ static struct key_vector *resize(struct trie *t, struct key_vector *tn) 
	/* Double as long as the resulting node has a number of

	 * nonempty nodes that are above the threshold.

	 */

	while (should_inflate(tp, tn) && max_work--) {

	while (should_inflate(tp, tn) && max_work) {

		tp = inflate(t, tn);

		if (!tp) {

#ifdef CONFIG_IP_FIB_TRIE_STATS
@@ -839,17 +839,21 @@ static struct key_vector *resize(struct trie *t, struct key_vector *tn) 
			break;

		}



		max_work--;

		tn = get_child(tp, cindex);

	}



	/* update parent in case inflate failed */

	tp = node_parent(tn);



	/* Return if at least one inflate is run */

	if (max_work != MAX_WORK)

		return node_parent(tn);

		return tp;



	/* Halve as long as the number of empty children in this

	 * node is above threshold.

	 */

	while (should_halve(tp, tn) && max_work--) {

	while (should_halve(tp, tn) && max_work) {

		tp = halve(t, tn);

		if (!tp) {

#ifdef CONFIG_IP_FIB_TRIE_STATS
@@ -858,6 +862,7 @@ static struct key_vector *resize(struct trie *t, struct key_vector *tn) 
			break;

		}



		max_work--;

		tn = get_child(tp, cindex);

	}
@@ -865,7 +870,7 @@ static struct key_vector *resize(struct trie *t, struct key_vector *tn) 
	if (should_collapse(tn))

		return collapse(t, tn);



	/* update parent in case inflate or halve failed */

	/* update parent in case halve failed */

	tp = node_parent(tn);



	/* Return if at least one deflate was run */

CRA Git | Maintained and supported by SUSTech CRA and CCSE