Commit b6ee376c authored Apr 01, 2016 by Thadeu Lima de Souza Cascardo Committed by David S. Miller Apr 05, 2016

ip6_tunnel: set rtnl_link_ops before calling register_netdevice

When creating an ip6tnl tunnel with ip tunnel, rtnl_link_ops is not set
before ip6_tnl_create2 is called. When register_netdevice is called, there
is no linkinfo attribute in the NEWLINK message because of that.

Setting rtnl_link_ops before calling register_netdevice fixes that.

Fixes: 0b112457 ("ip6tnl: add support of link creation via rtnl")
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com>
Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 727ceaa4

net/ipv6/ip6_tunnel.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -252,12 +252,12 @@ static int ip6_tnl_create2(struct net_device *dev)

		t = netdev_priv(dev);

		dev->rtnl_link_ops = &ip6_link_ops;
		err = register_netdevice(dev);
		if (err < 0)
		goto out;

		strcpy(t->parms.name, dev->name);
		dev->rtnl_link_ops = &ip6_link_ops;

		dev_hold(dev);
		ip6_tnl_link(ip6n, t);