Commit b6eae0f6 authored Sep 25, 2018 by Alexander Duyck Committed by Dan Williams Sep 26, 2018

libnvdimm: Hold reference on parent while scheduling async init



Unlike asynchronous initialization in the core we have not yet associated
the device with the parent, and as such the device doesn't hold a reference
to the parent.

In order to resolve that we should be holding a reference on the parent
until the asynchronous initialization has completed.

Cc: <stable@vger.kernel.org>
Fixes: 4d88a97a ("libnvdimm: ...base ... infrastructure")
Signed-off-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>

parent 3c5c98d1

drivers/nvdimm/bus.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -488,6 +488,8 @@ static void nd_async_device_register(void *d, async_cookie_t cookie)
		put_device(dev);
		}
		put_device(dev);
		if (dev->parent)
		put_device(dev->parent);
		}

		static void nd_async_device_unregister(void *d, async_cookie_t cookie)
		@@ -507,6 +509,8 @@ void __nd_device_register(struct device *dev)
		if (!dev)
		return;
		dev->bus = &nvdimm_bus_type;
		if (dev->parent)
		get_device(dev->parent);
		get_device(dev);
		async_schedule_domain(nd_async_device_register, dev,
		&nd_async_domain);

Admin message