Commit b6b1f19b authored Mar 06, 2017 by Aaron Armstrong Skomra Committed by Jiri Kosina Mar 21, 2017

HID: wacom: don't manually release resources for the EKR



Commit 5b779fc5 introduces the manual release of resources in wacom_remove() as
an addition to the driver's use of devm.  The EKR resources can only be
released through wacom_remote_destroy_one() so we skip the manual release for
it.

Fixes: 5b779fc5 ("HID: wacom: release the resources before leaving despite devm")
Signed-off-by: Aaron Armstrong Skomra <skomra@gmail.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent 49cc4c21

drivers/hid/wacom_sys.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -2579,6 +2579,8 @@ static void wacom_remove(struct hid_device *hdev)

		/* make sure we don't trigger the LEDs */
		wacom_led_groups_release(wacom);

		if (wacom->wacom_wac.features.type != REMOTE)
		wacom_release_resources(wacom);

		hid_set_drvdata(hdev, NULL);

Admin message