Commit b6aa1793 authored Dec 16, 2009 by Uwe Kleine-König Committed by Mark Brown Dec 22, 2009

ASoC: sh: FSI:: don't check platform_get_irq's return value against zero



platform_get_irq returns -ENXIO on failure, so !irq was probably
always true.  Better use (int)irq <= 0.  Note that a return value of
zero is still handled as error even though this could mean irq0.

This is a followup to 305b3228 that
changed the return value of platform_get_irq from 0 to -ENXIO on error.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

parent 48c03ce7

sound/soc/sh/fsi.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -876,7 +876,7 @@ static int fsi_probe(struct platform_device *pdev)

		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
		irq = platform_get_irq(pdev, 0);
		if (!res \|\| !irq) {
		if (!res \|\| (int)irq <= 0) {
		dev_err(&pdev->dev, "Not enough FSI platform resources.\n");
		ret = -ENODEV;
		goto exit;

Admin message